This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
Get rid of env var SERVICE_NAME #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allamand
suggested changes
Nov 26, 2019
|
@allamand I see. I even wonder why we still remove the node from its seeds list. I need to check if it's still needed |
cscetbon
force-pushed
the
clean-code
branch
2 times, most recently
from
f9b3ef0
to
aff54a3
Compare
allamand
approved these changes
Nov 29, 2019
cscetbon
added a commit
that referenced
this pull request
Aug 13, 2020
* clean-code - Remove env var SERVICE_NAME * clean-code - Remove Service from bootstrap image
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.