This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
Fix helm 3 crds installation + add some docs #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
@PERES-Richard are you sure helm2 still works with those changes ? #133 seems to say it doesn't. And if doesn't I think we can drop support for helm 2. |
cscetbon
suggested changes
Dec 3, 2020
PERES-Richard
changed the title
PERES-Richard
pushed a commit
that referenced
this pull request
Dec 8, 2020
cscetbon
previously approved these changes
Dec 8, 2020
cscetbon
reviewed
Dec 8, 2020
Co-authored-by: Cyril Scetbon <cscetbon@gmail.com>
PERES-Richard
added a commit
that referenced
this pull request
Dec 9, 2020
* Add kuttl test scenario scaleUP (WIP) * Test scale up with Kuttl * Add crds in helm directory (casskop & multicasskop) * Delete old beta crds * Update doc * Fix kuttl ScaleUp tests * Fix helm install CRD override * Add the necessary config for test parallelisation (random namespaces) & fix scaleup icarus assert incorrect matching * Add ScaleDown step * Rename test case folder * Add Kuttl to circleci build * Fix indent * Fix makefile * Update Makefile * Update CircleCI kuttl integration * Update config.yml * Update config.yml * Debug cci * Fix config * Add kuttl install circleci * Install brew * Install brew 2 * Fix brew * fix brew * Fix kuttl install * Update config.yml * Fix kuttl install in docker image * Update Dockerfile * Using binary kuttl for installation * Using binary kuttl for installation2 * Update Dockerfile * Update Dockerfile * use cci for kuttl * Update config.yml * Update config.yml * fix arg * Add helm installation * Add doc on "How to run kuttl tests" in developer guide * Remove useless namespace option in doc * Remove useless namespace option in doc (multi casskop) * Fix backup & restore doc example * Update and add spec of Backup & restore documentation * Remove old helm 2 docs refs * set cassandraCluster (with uppercase) in CRDs and definitions * update CRD * Fix tests * Log secret validation error * Update test with new typo * FIX undo some wrong typo changes * Fix test * Applied review asked changes * Rename test * Update with merge of #282 * Remove unused topology * Undo change post merge (distant repo not yet updated) * Fix test * Revert "Merge branch 'helm-3-install-crds' into bdd-testing" This reverts commit bb84620, reversing changes made to ba64023. * Remove event collect Co-authored-by: Cyril Scetbon <cscetbon@gmail.com>
Merged
fdehay
approved these changes
Dec 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Why?
The actual installation with helm 3 use a crd-install hook wich is depreciated in helm 3. With this fix you can now install Casskop (CRD + operator) with just 1 line of helm.
Additional context
It simply consist of copying CRDs from /deploy/crds to helm folders of Casskop & Multi Casskop.
Checklist
To Do