This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
Enforce HARDLINKS restore strategy as it is faster #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PERES-Richard
suggested changes
Jan 18, 2021
There was a problem hiding this comment.
I think this should be also removed :
And also the doc should be updated as well
https://github.com/Orange-OpenSource/casskop/blob/restore-strategy/website/docs/6_references/6_cassandra_restore.md
(in YAML example & table row)
|
@PERES-Richard I agree on the doc but not on the test. It's the response returned by the client and it always includes the restore strategy |
cscetbon
force-pushed
the
restore-strategy
branch
from
649c926
to
70692e8
Compare
Okey. I will test this new implem on our cluster to strongly make sure that this will not break backup & restore flows :) |
PERES-Richard
approved these changes
Jan 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORT restore strategy implies reading sstables and rewriting them which is longer that using hardlinks. That PR enforces that choice.