This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
Patch kuttl test to work with releases #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch init script to work for releases
cscetbon
suggested changes
Mar 14, 2021
| VERSION="$(awk -F\" '/Version =/ {print $2}' $BASEDIR/version/version.go)-release" | ||
| else | ||
| VERSION="$(awk -F\" '/Version =/ {print $2}' $BASEDIR/version/version.go)-$CIRCLE_BRANCH" | ||
| fi |
There was a problem hiding this comment.
@fdehay I would rather do
VERSION=${CIRCLE_TAG:-CIRCLE_BRANCH}
I don't think we need to check the file at any point as we already use the right version in the tag
|
CIRCLE_TAG is empty if you are not releasing / tagging.
And if we don't check the file we do not know the current version
Le dim. 14 mars 2021 à 04:38, Cyril Scetbon ***@***.***> a
écrit :
… ***@***.**** requested changes on this pull request.
------------------------------
In test/e2e/kuttl/ScaleUpAndDown/00-createCluster.yaml
<#307 (comment)>
:
> @@ -3,7 +3,12 @@ kind: TestStep
commands:
- script: |
BASEDIR=../../../..
- VERSION=$(awk -F\" '/Version =/ {print $2}' $BASEDIR/version/version.go)-$CIRCLE_BRANCH
+ if [ $CIRCLE_TAG ]
+ then
+ VERSION="$(awk -F\" '/Version =/ {print $2}' $BASEDIR/version/version.go)-release"
+ else
+ VERSION="$(awk -F\" '/Version =/ {print $2}' $BASEDIR/version/version.go)-$CIRCLE_BRANCH"
+ fi
@fdehay <https://github.com/fdehay> I would rather do
VERSION=${CIRCLE_TAG:-CIRCLE_BRANCH}
I don't think we need to check the file at any point as we already use the
right version in the tag
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#307 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4BEQM6FBF6MJCFC2FTOBTTDQOQPANCNFSM4YOWCAVA>
.
|
cscetbon
reviewed
Mar 17, 2021
Co-authored-by: Cyril Scetbon <cscetbon@gmail.com>
|
@fdehay any news on that PR ? Is it still needed ? |
cscetbon
approved these changes
May 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch init script to work for releases
What's in this PR?
Fix the image choosing algo to work with release tags in the kuttl ScaleUpandDown tests
Why?
Kuttl tests were failing when release were made