Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes setup toggle button for connection string. #1412

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Fixes setup toggle button for connection string. #1412

merged 1 commit into from
Jan 25, 2018

Conversation

jtkech
Copy link
Member

@jtkech jtkech commented Jan 25, 2018

So, as said in #1408

  • Changed the class with input-group-append and used a <button> with the fa icon.

  • Didn't find where the fa icon was swithched to show the state, maybe through bootstrap.

  • So, in the script at the end of the setup Index.cshtml (no need to use gulp) i just switched the fa icon class at the same place we swith the input type attribute between password and text.

toggle1

toggle2

@sebastienros sebastienros merged commit e3df05b into dev Jan 25, 2018
@jtkech jtkech deleted the toggle branch January 26, 2018 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants