Skip to content

Commit

Permalink
OM publish fix attempt
Browse files Browse the repository at this point in the history
  • Loading branch information
ginty committed Aug 5, 2024
1 parent 4136a25 commit c0f73cf
Showing 2 changed files with 7 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -96,14 +96,15 @@ jobs:
working-directory: python/origen_metal
run: |
echo "[build-system]" >> pyproject.toml
echo "requires = [\"maturin\>=1.0,<2.0\"]" >> pyproject.toml
echo "requires = [\"maturin>=1.0,<2.0\"]" >> pyproject.toml
echo "build-backend = \"maturin\"" >> pyproject.toml
- name: Build wheels
uses: PyO3/maturin-action@v1
with:
working-directory: python/origen_metal
target: x86_64
manylinux: auto
# This is required to fix an SSL build error
before-script-linux: yum install perl-IPC-Cmd -y
args: --release --strip --out dist --manifest-path ../../rust/pyapi_metal/Cargo.toml --interpreter python${{ matrix.python-version }}
- name: Install Poetry
@@ -121,8 +122,8 @@ jobs:

# SMcG - Couldn't get this to work with the manylinux2014_x86_64 container, I think the approach of running everything
# inside the manylinux container is wrong since many current Github action packages will not run in it.
# I've downgraded what I can and it gets far enough to build the wheels, but the actions/upload-artifact step needs v1
# to run in the container but this doesn't support the current Github actions workspace path
# I've fixed what I can and it gets far enough to build the wheels, but hit a roadblock since the actions/upload-artifact
# step needs v1 to run in the container but this doesn't support the current Github actions workspace path
#
# I've switched the OM build to use the Maturin action instead and I would recommend that the Origen job does similar
# in the future, it should be possible to include extra files like the origen binary in the wheel with Maturin.
3 changes: 3 additions & 0 deletions python/origen_metal/pyproject.toml
Original file line number Diff line number Diff line change
@@ -42,3 +42,6 @@ generate-setup-file = false
#[build-system]
#requires = ["maturin>=1.0,<2.0"]
#build-backend = "maturin"
[build-system]
requires = ["maturin>=1.0,<2.0"]
build-backend = "maturin"

0 comments on commit c0f73cf

Please sign in to comment.