Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STIL parser to keep all comments, not just annotations #201

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

rlaj
Copy link
Member

@rlaj rlaj commented Jun 13, 2024

No description provided.

@rlaj rlaj requested review from ginty and priyavadan June 13, 2024 14:30
@ginty
Copy link
Member

ginty commented Jun 13, 2024

Good update, would like to do more with STIL post-processing in the future to catch when transactions get optimized out-of-order and keeping the comments around for that will be necessary

Copy link
Member

@ginty ginty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlaj rlaj merged commit b02eee0 into feature/stil_updates Jun 13, 2024
12 checks passed
@rlaj rlaj deleted the feature/stil_updates_keep_comments branch June 13, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants