Monitoring rework #127
Merged
Monitoring rework #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation uses monitoring mutex lock on every iteration of the loop. It can be easily blocked by multiple monitoring queries. Let's reduce the scope of the lock. Signed-off-by: Vadim Fedorenko <vadfed@meta.com>
|
@agagniere can you take a look please? |
agagniere
reviewed
Apr 3, 2024
agagniere
reviewed
Apr 3, 2024
The GNSS info is collected in separate thread and it's better to prepare GNSS monitoring data filled in within the same thread. Introduce another mutex to reduce the scope of the lock section and avoid any double locks. Signed-off-by: Vadim Fedorenko <vadfed@meta.com>
vvfedorenko
force-pushed
the
monitoring_rework
branch
from
c2840d5 to
e23a965
Compare
|
adjusted the code |
agagniere
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the scope of monitoring mutex lock and move GNSS monitoring under another mutex with GNSS thread filling the data.