Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Test Cases #7

Open
adrienthiery opened this issue Jan 27, 2017 · 3 comments
Open

Automated Test Cases #7

adrienthiery opened this issue Jan 27, 2017 · 3 comments

Comments

@adrienthiery
Copy link
Contributor

adrienthiery commented Jan 27, 2017

Edge case URLs we are testing :

TODO :

  • google.com should provide an image
  • check out Medium articles

If you find any edge case that does not work, please put them here!

@henrytndrly
Copy link
Contributor

henrytndrly commented Jun 16, 2017

Possible: https://www.bbc.co.uk/news, where they have a protocol agnostic image tag:
<meta property="og:image" content="//m.files.bbci.co.uk/modules/bbc-morph-news-waf-page-meta/1.2.0/bbc_news_logo.png?cb=1">

adrienthiery pushed a commit that referenced this issue Jun 19, 2017
@adrienthiery adrienthiery changed the title Add Automated Tests Automated Test Cases Jul 4, 2017
@henrytndrly
Copy link
Contributor

I've found another test case where the ordering of content and property attributes was switched, which caused a problem with an older version of your metaTagOGRegex in OpenGraphParser.js: https://www.inverse.com/article/34343-a-i-scientists-react-to-elon-musk-ai-comments

The latest regex appears to work with this 'format', so just suggesting this as an additional test case.

@adrienthiery
Copy link
Contributor Author

Hi @henrytndrly,

Thanks, I'll add it later :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants