Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Commit

Permalink
Merge pull request #330 from arrase/feature/sonarqube-ingress-pathtype
Browse files Browse the repository at this point in the history
[sonarqube] ingress: Allow to configure pathType
  • Loading branch information
rjkernick authored Feb 7, 2022
2 parents 7517962 + 1257031 commit 0e2a95c
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/sonarqube/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
name: sonarqube
description: SonarQube is an open sourced code quality scanning tool
version: 9.9.2
version: 9.10.0
appVersion: 8.9.6-community
keywords:
- coverage
Expand Down
1 change: 1 addition & 0 deletions charts/sonarqube/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ The following table lists the configurable parameters of the Sonarqube chart and
| `ingress.labels` | Ingress additional labels | `{}` |
| `ingress.hosts[0].name` | Hostname to your SonarQube installation | `sonar.organization.com` |
| `ingress.hosts[0].path` | Path within the URL structure | / |
| `ingress.hosts[0].pathType` | [URL match type](https://kubernetes.io/docs/concepts/services-networking/ingress/#path-types) | Prefix |
| `ingress.hosts[0].serviceName` | Optional field to override the default serviceName of a path | None |
| `ingress.hosts[0].servicePort` | Optional field to override the default servicePort of a path | None |
| `ingress.tls` | Ingress secrets for TLS certificates | `[]` |
Expand Down
2 changes: 1 addition & 1 deletion charts/sonarqube/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ spec:
paths:
- path: {{ .path}}
{{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1" }}
pathType: Prefix
pathType: {{ .pathType }}
{{- end }}
backend:
{{- if $.Capabilities.APIVersions.Has "networking.k8s.io/v1" }}
Expand Down
3 changes: 3 additions & 0 deletions charts/sonarqube/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ ingress:
- name: sonar.organization.com
# Different clouds or configurations might need /* as the default path
path: /
# Only for API version "networking.k8s.io/v1"
# https://kubernetes.io/docs/concepts/services-networking/ingress/#path-types
pathType: Prefix
# For additional control over serviceName and servicePort
# serviceName: someService
# servicePort: somePort
Expand Down

0 comments on commit 0e2a95c

Please sign in to comment.