Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive header #185

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Responsive header #185

wants to merge 3 commits into from

Conversation

IvanR3D
Copy link
Contributor

@IvanR3D IvanR3D commented Jan 25, 2023

No description provided.

Modified the header to adapt small screens.
@cparrapa
Copy link
Member

Hi @IvanR3D great work I just tested in my desktop computer and resizing the window works but it came with couple of new issues:

image

  1. The language dropdown is not clickable in this new position and actually is better where it was before, away from the logo
  2. The Top bar height increased even when not resized, which is not a big deal to sacrifice
  3. A bottom empty space in dark blue appeared

How it looks in your laptop @logix5 ?

Thanks

@logix5
Copy link
Contributor

logix5 commented Jan 25, 2023 via email

@logix5
Copy link
Contributor

logix5 commented Jan 25, 2023 via email

Here I tried to fix the issues pointed by @camilo in the last commit. As extra changes: 
- Moved the lang selector to the middle of the top
- Moved the buttons in the workspace for: zoom and trash to the top of the workspace instead of the bottom.
@cparrapa
Copy link
Member

The resizing works great now @IvanR3D unfortunately there is big empty space now on the bottom that occupies most of the workspace and why having the language dropdown up there? it doesn't work and is better inline with the rest of the UI
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants