Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scenario archiving #1817

Merged
merged 5 commits into from
Oct 21, 2024
Merged

update scenario archiving #1817

merged 5 commits into from
Oct 21, 2024

Conversation

lastminutediorama
Copy link
Contributor

@lastminutediorama lastminutediorama commented Oct 17, 2024

This PR updates the actual archive/restore functions of the scenario card.
More specifically:

  • it adds/updates some icons
  • renames some fields from "status" to separate "archivedStatus" and "resultStatus", to avoid confusion
  • moves most of the archive/restore features to a different component
  • updates storybook defaults

@@ -2,15 +2,17 @@
*ngFor="let s of scenarios"
[name]="s.name"
[creator]="s.creator"
[areas]="getAreas(s)"
[areas]="numberOfAreas(s)"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this rename commit didn't land in a previous PR

creator: 'Larry Larrington',
created_at: '2024-01-01 12:34:00',
budget: 1234567,
treatmentPlansCount: 5,
userCanArchiveScenario: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaulting to true here just for Storybook purposes

@lastminutediorama lastminutediorama marked this pull request as ready for review October 18, 2024 16:03
@lastminutediorama lastminutediorama merged commit d25c4d4 into main Oct 21, 2024
6 checks passed
@lastminutediorama lastminutediorama deleted the update-scenario-archiving branch October 21, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants