-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logo-handling class and remote fetching of Ouranos logos #119
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Co-authored-by: juliettelavoie <juliette.lavoie@hotmail.ca>
This PR is complete IMO. The notebook shows failures since I killed one cell when running on my local machine. My other PR (#121) tries to fix this up in sphinx/RTD. |
View / edit / reply to this conversation on ReviewNB juliettelavoie commented on 2023-10-10T20:57:43Z Can we set 'ouranos_logo_vertical_couleur' as the default when installing it ? Zeitsperre commented on 2023-10-10T21:51:29Z This is now the case. |
This is now the case. View entire conversation on ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ouranos logo installation works great and it's nice to have all the other options (black, white, etc).
Using pathlib.Path(path in string) doesn't seems to work for me. Should I use pathlib another way?
Also, the error mesage due to the path not working tells me no logo are installed but this is not really the case as I am trying to show another logo than the installed one.
…to dependencies, support more intuitive logo-handling, add examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L'ajout de logo avec Pathlib.Path fonctionne et le logo de défaut installé aussi!
Je suppose que le "blurry" du logo d'Ouranos serait corrigé avec le fichier .svg envoyé par Sarah (plutôt que l'utilisation de .png)?
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
Logos
class for setting and installing logos to be usedplot_logo()
to accept apathlib.Path
to a location on disk or astr
identifying an installed logo.usage.rst
and some markdown cells infiganos_docs.ipynb
better detailing how the logos are installed and used.scikit-image
.Does this PR introduce a breaking change?
Yes. The Ouranos logos are not installed by default and will be removed from the repository and fetched on request from the
Ouranosinc/.github
repo. TheFiganos
logo is installed by default now.We also now depend on
scikit-image
for image resizing.Other information:
Some things that are missing so far:
Integration of the Logos class into thematplotlib
functions.Scaling of the logos according to the size of the output figures (Is this implemented? Yes)Scaling is related to the size of the PNGsDocumentation detailing how this works