Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facetgrid (multiplots) #136
Facetgrid (multiplots) #136
Changes from 10 commits
8230064
07595ab
41e471c
7cbc347
441bc17
4eff488
41cf877
e41e6e8
4ecc29a
9e47437
f09f641
55f99cb
148d9fc
9884fcc
51492bd
a52eeb1
e3123c5
8bb7f0c
ac31c00
3629618
b6c7da4
1c37ac5
68eb264
a09d974
eb564ae
28d7cb2
13fcf4a
e4a45d8
270bb67
0be84b3
1311e6e
6bd521d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comme il n'y a pas d'exemple ici, je l'enleverrais ou j'écrirais "Section coming soon".
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
juste une question d'esthétique. J'ajouterais
legend_kw={'ncol':4,'bbox_to_anchor':(0.15, 0.05)
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avec xclim 0.47, cette cellule brise parce que change_significance a une nouvelle signature.
https://xclim.readthedocs.io/en/stable/changes.html
change_significance va m[eme disparaitre à 0.49. but this can be fixed in another PR.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might change this to just " Multiple Plots"
Reply via ReviewNB