Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdfmap #54

Merged
merged 3 commits into from
Apr 4, 2023
Merged

gdfmap #54

merged 3 commits into from
Apr 4, 2023

Conversation

Beauprel
Copy link
Contributor

  • added function gdfmap
  • modified some utils
  • Added a test notebook (no internal paths) for this function. We can transfer its contents into the documentation notebook and delete it later.

@Beauprel Beauprel self-assigned this Mar 30, 2023
@Beauprel Beauprel linked an issue Mar 30, 2023 that may be closed by this pull request
Atlas-style maps #13
Closed
@Beauprel Beauprel mentioned this pull request Mar 30, 2023
Closed
juliettelavoie
juliettelavoie reviewed Mar 31, 2023
View reviewed changes
docs/notebooks/tests/gdfmap_test.ipynb Outdated Show resolved Hide resolved
spirograph/matplotlib/plot.py Outdated Show resolved Hide resolved
spirograph/matplotlib/plot.py Outdated Show resolved Hide resolved
spirograph/matplotlib/plot.py Show resolved Hide resolved
docs/notebooks/tests/gdfmap_test.ipynb Outdated Show resolved Hide resolved
juliettelavoie
juliettelavoie reviewed Apr 4, 2023
View reviewed changes
spirograph/matplotlib/utils.py
return ax


def clean_cmap_bounds(min: int | float, max: int | float, levels: int) -> np.ndarray:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je ne suis pas sur de comprendre à quoi ça sert..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentiellement juste à ce que le minimum et maximum de la colormap soient arrondis, et donc plus clean, avec le bénéfice supplémentaire que les subdivisions de la colormap seront aussi plus beaux, parce qu'on utilise linspace.

@Beauprel
Copy link
Contributor Author

Beauprel commented Apr 4, 2023

All comments above have been adressed

@Beauprel Beauprel merged commit de5447d into main Apr 4, 2023
@Beauprel Beauprel deleted the gdfmap branch April 4, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahclaude sarahclaude sarahclaude left review comments

@juliettelavoie juliettelavoie juliettelavoie approved these changes

Assignees

@Beauprel Beauprel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Atlas-style maps
3 participants
@Beauprel @juliettelavoie @sarahclaude