add violin plots fct #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliettelavoie
approved these changes
Apr 14, 2023
| plot_kw : dict, optional | ||
| Arguments to pass to the `seaborn.violinplot()` function. | ||
| color : str, int or list, optional | ||
| Unique color or list of colors to use. Integers point to the applied stylesheet's colors, in zero-indexed order. |
There was a problem hiding this comment.
I like that we can access the colors of the stylesheet!
There was a problem hiding this comment.
It would be nice to show them somewhere similarly to what you did in the color association section of the notebook. maybe in the stylesheet section of the notebook ?
|
|
||
| # set default use_attrs values | ||
| if "orient" in plot_kw and plot_kw["orient"] == "h": | ||
| use_attrs = {"xlabel": "long_name", "xunits": "units"} | use_attrs |
There was a problem hiding this comment.
I am wondering if we want vertical gridline when the violons are horizontal ?
sarahclaude
approved these changes
Apr 14, 2023
oui je l'ai ajouté dans ma branche! (pas encore push) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
violin()function and examples in docs.It wraps the seaborn function pretty thinly, but it:
use_attrs.I went with
violin()instead ofviolinplot()to not exactly mirror the seaborn name, but it can be modified.