Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent gridmap from modifying the features dict #74

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Prevent gridmap from modifying the features dict #74

merged 1 commit into from
Apr 26, 2023

Conversation

Beauprel
Copy link
Contributor

We were using pop to handle the scale of features in gridmap, causing the dictionary to be modified outside the function.

This seemes necessary, so I added a line to put the popped entries back in the dicionary.

@Beauprel Beauprel linked an issue Apr 25, 2023 that may be closed by this pull request
spiro modifies the features dict #70
Closed
juliettelavoie
juliettelavoie approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@juliettelavoie juliettelavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if we use pop somewhere else, that would need fixing also.

@Beauprel Beauprel merged commit 17dfa83 into main Apr 26, 2023
@Beauprel Beauprel deleted the 70-spiro-modifies-the-features-dict branch April 26, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliettelavoie juliettelavoie juliettelavoie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spiro modifies the features dict
2 participants
@Beauprel @juliettelavoie