Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less defaults in gdfmap #93

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Less defaults in gdfmap #93

merged 2 commits into from
Jun 2, 2023

Conversation

RondeauG
Copy link
Contributor

@RondeauG RondeauG commented Jun 2, 2023 •
edited
Loading

  • Removed the default features in gdfmap. I think this came from my old code, but it's not really instinctive (gridmap has no default) and we might not always want them. It's better to leave that control to the User.
  • Fixed the default projection when ax is provided.

EDIT: This should fix #91.

@RondeauG RondeauG mentioned this pull request Jun 2, 2023
Closed
juliettelavoie
juliettelavoie approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@juliettelavoie juliettelavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RondeauG RondeauG merged commit 554a621 into main Jun 2, 2023
@Zeitsperre Zeitsperre deleted the fix-gdf branch June 7, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliettelavoie juliettelavoie juliettelavoie approved these changes

@sarahclaude sarahclaude Awaiting requested review from sarahclaude

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect if projection is needed in gdfmap
2 participants
@RondeauG @juliettelavoie