-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subset-user-input.ipynb: fix output for Thredds v5 #317
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@tlogan2000 is |
It's not the same data no |
So it is not expected that with the new Thredds v5, |
@tvlu THREDDS sorting of datasets seems to have changed between v4 and v5. Two options to fix.
or
to
should ensure that v2 is found instead of v1 |
Is there an access by name instead of by index? Otherwise, the day we have Also, whether we choose |
for more information, see https://pre-commit.ci
Nothing built in but I change the code to search for |
Super, I'd do a "refresh" with Thredds v5 and test against our current Thredds v4. If it works, we can merge this immediately and be forward compatible with Thredds v5 ! |
Opps, closed by mistake. |
Replace by #342 |
…s v4 and v5 (#342) Original commit was from Travis 0a76235 Replaces PR #317 To avoid this error when we will upgrade to Thredds v5, while being backward compatible with current Thredds v4: ``` 15:47:13 ___ pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb::Cell 12 ___ 15:47:13 Notebook cell execution failed 15:47:13 Cell 12: Cell outputs differ 15:47:13 15:47:13 Input: 15:47:13 # gather data from the PAVICS data catalogue 15:47:13 catalog = "https://boreas.ouranos.ca/twitcher/ows/proxy/thredds/catalog/datasets/gridded_obs/catalog.xml" # TEST_USE_PROD_DATA 15:47:13 15:47:13 cat = TDSCatalog(catalog) 15:47:13 data = cat.datasets[0].access_urls["OPENDAP"] 15:47:13 data 15:47:13 15:47:13 Traceback: 15:47:13 mismatch 'text/plain' 15:47:13 15:47:13 assert reference_output == test_output failed: 15:47:13 15:47:13 "'https://pav...rcan_v2.ncml/'" == "'https://pav...s/nrcan.ncml'" 15:47:13 Skipping 70 identical leading characters in diff, use -v to show 15:47:13 - _obs/nrcan.ncml' 15:47:13 + _obs/nrcan_v2.ncml' 15:47:13 ? +++ 15:47:13 ```
Only merge if bird-house/birdhouse-deploy#413 can be merged.
This is mostly to have a nice notebook diff.