Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin numpy below v2.0.0 #1783

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Pin numpy below v2.0.0 #1783

merged 7 commits into from
Jun 17, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Jun 17, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Pins NumPy below v2.0.0 until xclim can be adjusted to the new API/ABI
  • Adds the NumPy development branch to the upstream repositories

Does this PR introduce a breaking change?

Yes, numpy is now pinned.

Other information:

https://numpy.org/devdocs/release/2.0.0-notes.html

@Zeitsperre Zeitsperre requested review from aulemahal and coxipi June 17, 2024 14:41
@Zeitsperre Zeitsperre requested review from SarahG-579462 and removed request for aulemahal June 17, 2024 14:48
SarahG-579462
SarahG-579462 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@SarahG-579462 SarahG-579462 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the approved Approved for additional tests label Jun 17, 2024
@Zeitsperre
Address scalar/dimension concatenation error (#1780)
61ca7a8 
### What kind of change does this PR introduce?

* Fixes a previously uncaught error where remnants of a scenario
selection were not being dropped properly.

### Does this PR introduce a breaking change?

No.
@coveralls
Copy link

Coverage Status

coverage: 90.594%. first build
when pulling 61ca7a8 on pin-numpy
into b7374de on main.

@Zeitsperre Zeitsperre merged commit bbd3267 into main Jun 17, 2024
19 checks passed
@Zeitsperre Zeitsperre deleted the pin-numpy branch June 17, 2024 15:20
@Zeitsperre Zeitsperre mentioned this pull request Jun 17, 2024
Closed
1 task
@larsbuntemeyer larsbuntemeyer mentioned this pull request Jul 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarahG-579462 SarahG-579462 SarahG-579462 approved these changes

@coxipi coxipi Awaiting requested review from coxipi

Assignees
No one assigned
Labels
approved Approved for additional tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeitsperre @coveralls @SarahG-579462