Sonar cloud improvements

OutSystems · Oct 7, 2024 · 41b0a38 · 41b0a38
1 parent cd43b82
commit 41b0a38
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/src/OutSystems/Maps/MapAPI/MarkerManager.ts b/src/OutSystems/Maps/MapAPI/MarkerManager.ts
@@ -233,13 +233,15 @@ namespace OutSystems.Maps.MapAPI.MarkerManager {
 			// Get all maps
 			const allMaps = [...MapManager.GetMapsFromPage().values()];
 
-			// On each map, look for all drawingTools and on each one look, on the createdElements array, for the markerId passed
+			// On each map, look for all drawingTools and on each one look,
+			// on the createdElements array, for the markerId passed.
 			allMaps.find((map: OSFramework.Maps.OSMap.IMap) => {
-				return (marker =
-					map.drawingTools &&
-					(map.drawingTools.createdElements.find((marker: OSFramework.Maps.Marker.IMarker) =>
-						marker.equalsToID(markerId)
-					) as OSFramework.Maps.Marker.IMarker));
+				if (map.drawingTools) {
+					marker = map.drawingTools.createdElements.find(
+						(marker: OSFramework.Maps.Marker.IMarker) => marker && marker.equalsToID(markerId)
+					) as OSFramework.Maps.Marker.IMarker;
+				}
+				return marker;
 			});
 
 			// If still wasn't found, then it does not exist and throw error

diff --git a/src/Providers/Maps/Google/Marker/DeprecatedMarker.ts b/src/Providers/Maps/Google/Marker/DeprecatedMarker.ts
@@ -9,7 +9,7 @@ namespace Provider.Maps.Google.Marker {
 		>
 		implements IMarkerGoogle
 	{
-		private _addedEvents: Array<string>;
+		private readonly _addedEvents: Array<string>;
 
 		constructor(
 			map: OSFramework.Maps.OSMap.IMap,

diff --git a/src/Providers/Maps/Google/Marker/Marker.ts b/src/Providers/Maps/Google/Marker/Marker.ts
@@ -9,7 +9,7 @@ namespace Provider.Maps.Google.Marker {
 		>
 		implements IMarkerGoogle
 	{
-		private _addedEvents: Array<string>;
+		private readonly _addedEvents: Array<string>;
 
 		constructor(
 			map: OSFramework.Maps.OSMap.IMap,