Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jakarta upgrade #60

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Conversation

smahieu87
Copy link
Contributor

Pull Request Description

Please include a summary of the change request or bug which is supposed to be fixed as part of this pull request

Type of Pull Request

  • New feature/Enhancement - non-breaking change which adds functionality
  • Bug fix
  • Breaking change (Require Major version change?)

Type of Change

  • OpenPeppol AS2/AS4 specification
  • OpenPeppol Spring/Fall release
  • Oxalis software change or enhancement
  • CEF change

Pull Request Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas. But did not added unnecessary annotation/comment say @author name etc
  • I have checked my code for variable and method name and corrected grammar/spelling mistakes if any
  • I have made corresponding changes to the documentation where needed
  • My changes generate no new/additional warnings
  • My change is not breaking or creating conflict with associated dependencies
  • I have performed a self-review of my own code
  • I ran mvn clean install before commit and all tests run successfully
  • I conducted basic QA to assure all features are working fine
  • My pull request generate no conflicts with master branch
  • I requested code review from other team members

Copy link
Member

@aaron-kumar aaron-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smahieu87, I am approving pull request with following comments:

  1. Do not use SNAPSHOT version of dependency (commons-certvalidator and peppol-specifications), instead first allow dependency to be published.
  2. Do not add more than one change in one Pull request (e.g. dnsjava)

I will fix the thing up after merging pull request.

@aaron-kumar aaron-kumar self-assigned this Oct 26, 2024
@aaron-kumar aaron-kumar merged commit dc86203 into OxalisCommunity:master Oct 26, 2024
1 of 2 checks passed
@aaron-kumar
Copy link
Member

Issue related to SNAPSHOT version as you can see in build fail is fixed as part of commit: fa37fd7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Q4 2024 - September - December
Development

Successfully merging this pull request may close these issues.

2 participants