test/threads: fix state leakage across tests #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_threaded_bad_options was only passing in CI because it was running after test_threaded_invalid_binary, which altered the base class to ignore some exceptions. Restructure the tests by using the fact that ThreadedAustin.join will bubble up any exception that happened during startup. This avoids manipulating global state in test_threaded_invalid_binary. Fixes P403n1x87#13.
delroth
force-pushed
the
test-threads-leakage
branch
from
473501f
to
b1bbc43
Compare
Codecov ReportBase: 73.79% // Head: 73.79% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage 73.79% 73.79%
=======================================
Files 14 14
Lines 1309 1309
Branches 199 199
=======================================
Hits 966 966
Misses 289 289
Partials 54 54 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
P403n1x87
reviewed
Oct 31, 2022
P403n1x87
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please double check that I didn't significantly alter the semantics of test_threaded_invalid_binary -- to me the before/after seem equivalent but I might be missing some subtlety, having a total of 15min of experience in this codebase :-)
Description of the Change
test_threaded_bad_options was only passing in CI because it was running after test_threaded_invalid_binary, which altered the base class to ignore some exceptions.
Restructure the tests by using the fact that ThreadedAustin.join will bubble up any exception that happened during startup. This avoids manipulating global state in test_threaded_invalid_binary.
Fixes #13.
Alternate Designs
n/a
Regressions
Test only change.
Verification Process
Used
pytestto run the two suspect tests in isolation and confirmed they now both pass in this environment. Confirmed they also still both pass when ran together.