Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default realm = "REALM" is always written although not required by CV #736

Closed
larsbuntemeyer opened this issue Apr 10, 2024 · 2 comments · Fixed by #741
Closed

default realm = "REALM" is always written although not required by CV #736

larsbuntemeyer opened this issue Apr 10, 2024 · 2 comments · Fixed by #741
Milestone

Comments

@larsbuntemeyer
Copy link

I think this is a similar issue as #727. For CORDEX, we have eliminated the realm attribute from the required global attributes (and also from table headers). However, cmor will write a default of realm = REALM (example) no matter what.

@durack1
Copy link
Contributor

durack1 commented Apr 17, 2024

@larsbuntemeyer agreed, this could be an opportunity to further reduce hard-coding of global attributes, with such items managed through a required_global_attributes.json input file. If there are other obvious cases like this, ping back on this thread and we'll consider this as the 3.9 cleanup work continues.

It it wasn't obvious, we have realm explicitly defined by mip-cmor-tables (with interpretation, e.g. APmon = atmospheric physics monthly, OPmon = ocean physics monthly, AEday = atmospheric aerosol daily, OBmon = ocean biogeochemistry monthly, etc), so there may be opportunities to further reduce global attribute clutter.

@larsbuntemeyer
Copy link
Author

Thanks @durack1 , i'll check in here again if we find something similar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants