Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make further_info_url attribute only be used if required by CV or requested by user #727

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

mauzey1
Copy link
Collaborator

@mauzey1 mauzey1 commented Feb 16, 2024

This PR will make CMOR only add a further_info_url attribute to the file if it is either required by the CV, or set in the user input file. If further_info_url is in the required_global_attributes section of the CV, it will require CMOR to add that attribute to the file.

The further_info_url attribute value provided by the user in the input file is a template that will be used by CMOR to generate a URL. If the user doesn't provide a template value when it is required, then CMOR will use its built-in default template for the URL. If the CV file provides a value for further_info_url in the source_id entry, then it will be used as a value for the file's attribute unless further_info_url is set in the user input.

@durack1 durack1 self-requested a review February 16, 2024 22:10
@mauzey1 mauzey1 marked this pull request as ready for review February 20, 2024 19:33
Copy link
Collaborator

@piotr-florek-mohc piotr-florek-mohc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, and the code behaves as expected, with CMOR complaining about missing attribute if I put further_info_url back into CVs.

@mauzey1 mauzey1 merged commit 10bb94a into main Feb 27, 2024
10 checks passed
@mauzey1 mauzey1 deleted the 718-remove-unused-global-attributes branch February 27, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants