Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if "external_variables" exists when values are present in "cell_measures". #568

Merged
merged 4 commits into from
Dec 21, 2019
Merged

Check if "external_variables" exists when values are present in "cell_measures". #568

merged 4 commits into from
Dec 21, 2019

Conversation

mauzey1
Copy link
Collaborator

@mauzey1 mauzey1 commented Dec 19, 2019

Resolves #541

durack1
durack1 approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@durack1 durack1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauzey1 looks good to me, it also seems all the linux tests have passed

@mauzey1
Copy link
Collaborator Author

mauzey1 commented Dec 20, 2019

@durack1 @taylor13 @sashakames
I have added another change that will check if realization_index, initialization_index, physics_index, and forcing_index are missing from the global attributes before trying to check if they are integers.

@durack1 durack1 self-requested a review December 21, 2019 00:33
durack1
durack1 approved these changes Dec 21, 2019
View reviewed changes
Copy link
Contributor

@durack1 durack1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauzey1 sorry I missed the updated PR, this looks better than the last

@mauzey1 mauzey1 merged commit 7580748 into master Dec 21, 2019
@mauzey1 mauzey1 deleted the prepare_external_variables_error branch December 21, 2019 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durack1 durack1 durack1 approved these changes

@taylor13 taylor13 Awaiting requested review from taylor13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear why Files SKIPPED
2 participants
@mauzey1 @durack1