Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages for supported data types in pywrapper #581

Merged
merged 8 commits into from
Mar 10, 2020
Merged

Improve error messages for supported data types in pywrapper #581

merged 8 commits into from
Mar 10, 2020

Conversation

mauzey1
Copy link
Collaborator

@mauzey1 mauzey1 commented Feb 21, 2020

Resolves #542

@mauzey1 mauzey1 mentioned this pull request Mar 5, 2020
Closed
sterlingbaldwin
sterlingbaldwin suggested changes Mar 6, 2020
View reviewed changes
Lib/pywrapper.py Outdated Show resolved Hide resolved
@sterlingbaldwin sterlingbaldwin self-requested a review March 10, 2020 20:25
sterlingbaldwin
sterlingbaldwin approved these changes Mar 10, 2020
View reviewed changes
Copy link
Collaborator

@sterlingbaldwin sterlingbaldwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes I suggested.

@mauzey1 mauzey1 merged commit 0268181 into master Mar 10, 2020
@mauzey1 mauzey1 deleted the 542_error_message_mismatch branch March 10, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sterlingbaldwin sterlingbaldwin sterlingbaldwin approved these changes

@durack1 durack1 durack1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message mis-match
3 participants
@mauzey1 @durack1 @sterlingbaldwin