Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMOR 3.7.3 #716

Merged
merged 4 commits into from
Oct 17, 2023
Merged

CMOR 3.7.3 #716

merged 4 commits into from
Oct 17, 2023

Conversation

mauzey1
Copy link
Collaborator

@mauzey1 mauzey1 commented Oct 11, 2023 •
edited
Loading

Changes

  • CMOR now supports Python 3.12.

Bugfixes

  • Fixed error caused when cmor_write writes arrays with more than 231-1 elements.
  • Fixed segmentation fault casued when the value for further_info_url in the user input is an empty string or only whitespace.
  • Fixed implicit declaration compilation error in cmor.c.

Closed Issues

@mauzey1
Copy link
Collaborator Author

mauzey1 commented Oct 12, 2023

@piotr-florek-mohc If you have the time, please review and approve this PR. I plan to publish the new release either tomorrow or next Monday.

piotr-florek-mohc
piotr-florek-mohc approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@piotr-florek-mohc piotr-florek-mohc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mauzey1 mauzey1 merged commit 63a431d into main Oct 17, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-florek-mohc piotr-florek-mohc piotr-florek-mohc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauzey1 @piotr-florek-mohc