Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

886 msa precip variability xcdat #889

Merged
merged 5 commits into from
Nov 21, 2022
Merged

Conversation

msahn
Copy link
Collaborator

@msahn msahn commented Nov 11, 2022

The code for precip variability across timescales has been updated to use xCDAT. I have tested it with oservational and model data and there was no issue.

Demo notebooks: using CDAT, using xCDAT

@msahn msahn requested a review from lee1043 November 11, 2022 18:45
@lee1043
Copy link
Contributor

lee1043 commented Nov 11, 2022

@msahn looks great, thank you for adding this. One more thing that could be added is dependency in the dev.yml file. The latest xcdat is v0.4.0. Could you please check your code is working okay with xcdat v0.4.0 and add xcdat=0.4.0 in the dependency list?

@lee1043 lee1043 linked an issue Nov 21, 2022 that may be closed by this pull request
@lee1043 lee1043 merged commit d0775e2 into main Nov 21, 2022
@lee1043 lee1043 deleted the 886_msa_precip_variability_xcdat branch November 21, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert precip variability code to use xCDAT
2 participants