Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use __builtin_unreachable() in PCRE2_ASSERT() #485

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not use __builtin_unreachable() in PCRE2_ASSERT() #485

wants to merge 1 commit into from
+3 −32

Commits on Sep 20, 2024

  1. Do not use __builtin_unreachable() in PCRE2_ASSERT() 

    __builting_unreachable() implementation is not defined and has
been known to not trigger failures under some compilers.

Default instead to using assert(), which has the added benefit
of printing a descriptive message and it is also likely more
portable as it is part of ANSI C.

While at it, really allow configuring builtins with cmake.
    @carenas
    carenas committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e006b51 View commit details
    Browse the repository at this point in the history