Skip to content

Commit

Permalink
Vif: Replace some asserts with logs.
Browse files Browse the repository at this point in the history
The conditions need hardware testing.
Use logs instead so the games are still playable.
  • Loading branch information
lightningterror committed Nov 22, 2024
1 parent 9417996 commit fdb9592
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
4 changes: 3 additions & 1 deletion pcsx2/arm64/Vif_Dynarec.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,9 @@ void VifUnpackNEON_Dynarec::ModUnpack(int upknum, bool PostOp)
case 3:
case 7:
case 11:
pxFailRel(fmt::format("Vpu/Vif - Invalid Unpack! [{}]", upknum).c_str());
// TODO: Needs hardware testing.
// Dynasty Warriors 5: Empire - Player 2 chose a character menu.
Console.Warning("Vpu/Vif: Invalid Unpack %d", upknum);
break;
}
}
Expand Down
3 changes: 2 additions & 1 deletion pcsx2/arm64/Vif_UnpackNEON.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,8 @@ void VifUnpackNEON_Base::xUnpack(int upknum) const
case 3:
case 7:
case 11:
pxFailRel(fmt::format("Vpu/Vif - Invalid Unpack! [{}]", upknum).c_str());
// TODO: Needs hardware testing.
Console.Warning("Vpu/Vif: Invalid Unpack %d", upknum);
break;
}
}
Expand Down
4 changes: 3 additions & 1 deletion pcsx2/x86/Vif_Dynarec.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,9 @@ void VifUnpackSSE_Dynarec::ModUnpack(int upknum, bool PostOp)
case 3:
case 7:
case 11:
pxFailRel(fmt::format("Vpu/Vif - Invalid Unpack! [{}]", upknum).c_str());
// TODO: Needs hardware testing.
// Dynasty Warriors 5: Empire - Player 2 chose a character menu.
Console.Warning("Vpu/Vif: Invalid Unpack %d", upknum);
break;
}
}
Expand Down
3 changes: 2 additions & 1 deletion pcsx2/x86/Vif_UnpackSSE.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,8 @@ void VifUnpackSSE_Base::xUnpack(int upknum) const
case 3:
case 7:
case 11:
pxFailRel(fmt::format("Vpu/Vif - Invalid Unpack! [{}]", upknum).c_str());
// TODO: Needs hardware testing.
Console.Warning("Vpu/Vif: Invalid Unpack %d", upknum);
break;
}
}
Expand Down

0 comments on commit fdb9592

Please sign in to comment.