PCRTC/Counters: Fix H-Blanks per frame #10199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrlinkwii
approved these changes
Oct 29, 2023
kamfretoz
approved these changes
Oct 29, 2023
JordanTheToaster
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes the H-Blanks per frame according to testing.
Also fix a bug in checking if it's NTSC
Rationale behind Changes
The numbers were slightly out, I retested them and they match pretty closely now.
Suggested Testing Steps
Smoke test some games, maybe try some games with incorrect field orders, might be better now..
cycles values are bus cycles/256
Progressive NTSC
PCSX2
bus cycles during vblank 842 vrender 8785 vblank 842
blanks during vblank 23 vrender 240 vblank 23
PS2
bus cycles during vblank 842 vrender 8785 vblank 841
blanks during vblank 23 vrender 240 vblank 23
Progressive PAL
PCSX2
bus cycles during vblank 959 vrender 10617 vblank 958
blanks during vblank 26 vrender 288 vblank 26
PS2
bus cycles during vblank 958 vrender 10616 vblank 958
blanks during vblank 26 vrender 288 vblank 26
Interlaced NTSC
PCSX2
bus cycles during vblank 824 vrender 8786 vblank 823
blanks during vblank 23 vrender 240 vblank 22
PS2
bus cycles during vblank 823 vrender 8785 vblank 823
blanks during vblank 23 vrender 240 vblank 22
Interlaced PAL
PCSX2
bus cycles during vblank 903 vrender 10617 vblank 903
blanks during vblank 25 vrender 288 vblank 24
PS2
bus cycles during vblank 903 vrender 10616 vblank 903
blanks during vblank 25 vrender 288 vblank 24