Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: Refactor nocash symbol importer #11946

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

chaoticgd
Copy link
Contributor

@chaoticgd chaoticgd commented Oct 25, 2024

Description of Changes

  • Improve error handling.
  • Create type name AST nodes instead of built-in nodes. This means different types will be shown in the global variables tab for these symbols e.g. u8 instead of 8-bit unsigned integer.
  • Use FileSystem::OpenManagedCFile instead of FileSystem::OpenCFile.

Rationale behind Changes

  • Silence a spammy error message.
  • The previous behaviour with the built-in AST node made the type more annoying the edit in the debugger.

Suggested Testing Steps

  • Make sure any .sym files you have are still being imported correctly.

@chaoticgd chaoticgd force-pushed the nocash_refactor branch 2 times, most recently from a162b23 to ca05c8c Compare October 25, 2024 08:58
@chaoticgd
Copy link
Contributor Author

Updated to use u8/u16/u32 instead of unsigned char/unsigned short/unsigned int. Probably a bit more user friendly.

@lightningterror lightningterror added this to the Release 2.4 milestone Oct 30, 2024
@F0bes F0bes merged commit 4dafee1 into PCSX2:master Nov 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants