Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/Appimage: Suppress error when no tags are present #12106

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

TheLastRar
Copy link
Contributor

Description of Changes

Suppress the error return code for git describe --tags

Rationale behind Changes

This command will return error if the repo has zero tags
We already handle the failure by checking the stdout of the command (which is empty as the error message goes to stderr)

Suggested Testing Steps

Test this change on a fork that lacks tags
I've tested locally, but I've not tested on the CI

Copy link
Member

@F0bes F0bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@F0bes F0bes merged commit f509fb6 into PCSX2:master Dec 24, 2024
12 checks passed
@TheLastRar TheLastRar deleted the ci-no-tag-no-fail branch December 24, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants