Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup GIL stuff #157

Merged
merged 9 commits into from
Jan 5, 2024
Merged

Cleanup GIL stuff #157

merged 9 commits into from
Jan 5, 2024

Conversation

hobu
Copy link
Member

@hobu hobu commented Jan 4, 2024

  • executeStream already does GIL release
  • pybind11 does GIL acquisition with each call, we don't need to be doing that everywhere

@hobu
executeStream already does GIL release, we don't need to do it. pybin…
6bcdde9 
…d11 does GIL acquire with every method call so we don't need to be doing that either
@hobu hobu added this to the 3.3.1 milestone Jan 4, 2024
@hobu hobu merged commit dc8b1b5 into main Jan 5, 2024
26 checks passed
@hobu hobu deleted the de-gil-acquire branch January 5, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.
1 participant
@hobu