Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump gdal #127

Merged
merged 2 commits into from
Jul 18, 2024
Merged

bump gdal #127

merged 2 commits into from
Jul 18, 2024

Conversation

botenvouwer
Copy link
Collaborator

Description

Bump GDAL to 3.9.1

Type of change

  • Minor change (typo, formatting, version bump)

@Shalucik
Copy link
Member

@botenvouwer @RoelvandenBerg
ik denk dat de required status checks in de branch protections aangepast moeten worden op basis van de nieuwe testmatrix

@rkettelerij
Copy link
Collaborator

rkettelerij commented Jul 17, 2024 •
edited
Loading

In kader van commit hygiëne misschien even een git squash/rebase doen. Zodat er 1 duidelijke commit uit komt.

RoelvandenBerg
RoelvandenBerg requested changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@RoelvandenBerg RoelvandenBerg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Op hoofdlijnen ok. Paar vragen / kleine dingen om nog op te schonen.

.github/workflows/pytest.yml Outdated Show resolved Hide resolved
geopackage_validator/utils.py Outdated Show resolved Hide resolved
geopackage_validator/validate.py Outdated Show resolved Hide resolved
tests/test_utils.py Show resolved Hide resolved
tests/test_validate.py Outdated Show resolved Hide resolved
@botenvouwer
Bump GDAL to 3.9.1
76f9e12 
Fixed test matirx
Changed error handling for GDAL in reverse compatible manner
Fixed unit tests accordingly
@botenvouwer
Bump GDAL to 3.9.1
2cc04be 
Fixed test matirx
Changed error handling for GDAL in reverse compatible manner
Fixed unit tests accordingly
@botenvouwer botenvouwer merged commit aa5afc9 into master Jul 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoelvandenBerg RoelvandenBerg RoelvandenBerg approved these changes

@roelarents roelarents Awaiting requested review from roelarents

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@botenvouwer @Shalucik @rkettelerij @RoelvandenBerg