Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add captions #16

Merged
merged 10 commits into from
Dec 1, 2023
Merged

chore: add captions #16

merged 10 commits into from
Dec 1, 2023

Conversation

gouzil
Copy link
Contributor

@gouzil gouzil commented Nov 28, 2023

添加图注

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for pfccblog ready!

Name Link
🔨 Latest commit 28bbfb0
🔍 Latest deploy log https://app.netlify.com/sites/pfccblog/deploys/6569448a86fb990008f3b05c
😎 Deploy Preview https://deploy-preview-16--pfccblog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gouzil gouzil changed the title chore: fix typos chore: add captions Nov 28, 2023
<img src="../images/chuan-story/chuan-04.jpg" alt="chuan-04" style="width: 33%;">
<img src="../images/chuan-story/chuan-05.jpg" alt="chuan-05" style="width: 33%;">
<img src="../images/chuan-story/chuan-06.jpg" alt="chuan-06" style="width: 33%;">
<center style="width: 33%;">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

别用 center 了,已经 Deprecated 了

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/center

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已替换

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处的命名和写法可能有些问题

@SigureMo SigureMo self-requested a review November 28, 2023 17:41
@@ -161,7 +162,7 @@ import MessageBox from '../.vitepress/components/MessageBox.vue'
</Message>
</MessageBox>

### by 卢师傅([sanbuphy](https://github.com/sanbuphy))
### by 卢师傅([AndSonder](https://github.com/AndSonder))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunzhongkai588 孙师傅出来挨打!

Comment on lines 11 to 17
const src = computed(() => {
return url
})

const alt = computed(() => {
return describe
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这直接用不就好了,不用再改成计算属性

Comment on lines 19 to 33
const centerstyle = computed(() => {
const centerStyle_ = centerStyle ?? null
if (centerStyle_ == null) {
return 'text-align: center'
} else {
return centerStyle + 'text-align: center'
}
})

const legendstyles = computed(() => {
return (
legendStyle ??
'color: orange;border-bottom: 1px solid #d9d9d9;display: inline-block;color: #999;padding: 2px;'
)
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这俩自定义需求高么?不高感觉直接写死就好

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不太高,而且我觉得全部统一更好

</div>

![chuan-07](../images/chuan-story/chuan-07.jpg)
<ImageBox url="../images/chuan-story/chuan-07.jpg" describe="平潭(来源: 新华社2023/04/29 )"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ImageBox url="../images/chuan-story/chuan-07.jpg" describe="平潭(来源: 新华社2023/04/29 )"/>
<ImageBox url="../images/chuan-story/chuan-07.jpg" describe="平潭(来源: 新华社 2023/04/29 )"/>


const { url, describe, centerStyle, legendStyle } = defineProps<{
url: string
describe: string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
describe: string
description: string

![chuan-14](../images/chuan-story/chuan-14.jpg)

![chuan-15](../images/chuan-story/chuan-15.jpg)
<ImageBox url="../images/chuan-story/chuan-14.jpg" describe="北京798艺术区"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ImageBox url="../images/chuan-story/chuan-14.jpg" describe="北京798艺术区"/>
<ImageBox url="../images/chuan-story/chuan-14.jpg" describe="北京 798 艺术区"/>

@gouzil
Copy link
Contributor Author

gouzil commented Nov 29, 2023

需要确认一下图片为啥加载不出来,本地dev可以

@jzhang533
Copy link
Contributor

这个可以合入了嘛

@SigureMo
Copy link
Collaborator

还不可以,现在渲染是有问题的,等有时间再看看

@SigureMo
Copy link
Collaborator

SigureMo commented Dec 1, 2023

先不用组件了

@SigureMo SigureMo enabled auto-merge December 1, 2023 02:29
Copy link
Collaborator

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@SigureMo SigureMo added this pull request to the merge queue Dec 1, 2023
Merged via the queue into PFCCLab:main with commit 0b8451c Dec 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants