Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numbers::is*(): remove fault tolerance for invalid numeric literals with underscores #620

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Numbers::is*(): remove fault tolerance for invalid numeric literals with underscores #620

merged 2 commits into from
Aug 19, 2024

Commits on Aug 19, 2024

  1. Numbers::is*(): remove fault tolerance for invalid numeric literals w… 

    …ith underscores

Numeric literals with underscores have restrictions as to where the underscores are allowed.

The `Numbers` class did not take this into account to have some allowance for developer error, but as a bug has now been reported for the `AbstractArrayDeclarationSniff::getActualArrayKey()` method, which is due to this fault tolerance, the fault tolerance will be removed and the `Numbers::is*()` methods will now only allow underscore separators in places where PHP allows them.

Note: There is still one restriction which is not yet handled: `1__1`, i.e. two underscores next to each.
If at some point in the future a bug for this would be reported, this can be reconsidered.

Includes a plenitude of additional tests.

Fixes 619

Refs:
* https://wiki.php.net/rfc/numeric_literal_separator#restrictions
    @jrfnl
    jrfnl committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    eaa0cf7 View commit details
    Browse the repository at this point in the history

  2. AbstractArrayDeclarationSniff::getActualArrayKey(): add extra tests

    @jrfnl
    jrfnl committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5501cbe View commit details
    Browse the repository at this point in the history