Generic/UnnecessaryFinalModifier: improve code coverage #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigoprimo
force-pushed
the
test-coverage-unnecessary-final-modifier
branch
from
6cab32b
to
93c83e3
Compare
jrfnl
reviewed
Jan 12, 2024
There was a problem hiding this comment.
Thanks for this PR @rodrigoprimo !
I considered adding more tests with different class definitions, but I was not able to think of examples that felt relevant enough and also different enough from the tests that are already in place.
What about adding some tests with final class constants as allowed since PHP 8.1 ?
|
Thanks for the review, @jrfnl!
Good point, I just pushed a new commit adding tests with final class constants. |
jrfnl
approved these changes
Jan 12, 2024
Doing this to be able to create a test with a syntax error on a separate file.
This commit add one more test case file to exercise defensive code that makes the sniff bail early if the class has no body.
jrfnl
force-pushed
the
test-coverage-unnecessary-final-modifier
branch
from
d1c0413
to
d09b571
Compare
|
FYI: I've rebased the PR without changes to get the code coverage to report. Will merge once the build passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the code coverage of the Generic.CodeAnalysis.UnnecessaryFinalModifier sniff. There was only one line that was not already exercised by the tests that bails early if it finds a class without a body.
I considered adding more tests with different class definitions, but I was not able to think of examples that felt relevant enough and also different enough from the tests that are already in place.
Related issues/external references
Part of #146
Types of changes
PR checklist