PSR2/UseDeclaration - refine testcase #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this test-case was always intended to be a parse error, it wasn't intended to be _that_ parse error. The initial intention was that this particular case (unfinished group) not be fixable. That was the case when the code was initially written, but a later change enabled the auto-fixer and broke this. I have opened <PHPCSStandards#333> to track the incorrect fixer changes being applied in the other parse error case.
jrfnl
approved these changes
Feb 8, 2024
fredden
deleted the
missing-fixed-file/psr2-namespaces/use-declaration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While this test-case was always intended to be a parse error, it wasn't intended to be that parse error. The initial intention was that this particular case (unfinished group) not be fixable. That was the case when the code was initially written, but a later change enabled the auto-fixer and broke this.
I have opened #333 to track the incorrect fixer changes being applied in the other parse error case.
This is related to #299
Suggested changelog entry
This is probably not worth its own entry in the change-log.
Types of changes
PR checklist