Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to all issues in the 2.2.0, 2.1.0, and 2.0.0 sections of the changelog #409

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 94 additions & 46 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3800,53 +3800,77 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
- PHP and JS functions and closures are now treated the same way
- Squiz MultiLineFunctionDeclarationSniff now supports JS files
- Interactive mode no longer breaks if you also specify a report type on the command line
- PEAR InlineCommentSniff now fixes the Perl-style comments that it finds (request #375)
- PEAR InlineCommentSniff now fixes the Perl-style comments that it finds (request [#375][sq-375])
- PSR2 standard no longer fixes the placement of docblock open tags as comments are excluded from this standard
- PSR2 standard now sets a default tab width of 4 spaces
- Generic DocCommentSniff now only disallows lowercase letters at the start of a long/short comment (request #377)
- Generic DocCommentSniff now only disallows lowercase letters at the start of a long/short comment (request [#377][sq-377])
- All non-letter characters are now allowed, including markdown special characters and numbers
- Generic DisallowMultipleStatementsSniff now allows multiple open/close tags on the same line (request #423)
- Generic CharacterBeforePHPOpeningTagSniff now only checks the first PHP tag it finds (request #423)
- Generic CharacterBeforePHPOpeningTagSniff now allows a shebang line at the start of the file (request #20481)
- Generic InlineHTMLUnitTest now allows a shebang line at the start of the file (request #20481)
- Generic DisallowMultipleStatementsSniff now allows multiple open/close tags on the same line (request [#423][sq-423])
- Generic CharacterBeforePHPOpeningTagSniff now only checks the first PHP tag it finds (request [#423][sq-423])
- Generic CharacterBeforePHPOpeningTagSniff now allows a shebang line at the start of the file (request [#20481][pear-20481])
- Generic InlineHTMLUnitTest now allows a shebang line at the start of the file (request [#20481][pear-20481])
- PEAR ObjectOperatorIndentSniff now only checks object operators at the start of a line
- PEAR FileComment and ClassComment sniffs no longer have @ in their error codes
- E.g., PEAR.Commenting.FileComment.Missing@categoryTag becomes PEAR.Commenting.FileComment.MissingCategoryTag
- Thanks to [Grzegorz Rygielski][@grzr] for the patch
- Squiz ControlStructureSpacingSniff no longer enforces a blank line before CATCH statements
- Squiz FunctionCommentSniff now fixes the return type in the @return tag (request #392)
- Squiz FunctionCommentSniff now fixes the return type in the @return tag (request [#392][sq-392])
- Squiz BlockCommentSniff now only disallows lowercase letters at the start of the comment
- Squiz InlineCommentSniff now only disallows lowercase letters at the start of the comment
- Squiz OperatorSpacingSniff now has a setting to ignore newline characters around operators (request #348)
- Squiz OperatorSpacingSniff now has a setting to ignore newline characters around operators (request [#348][sq-348])
- Default remains FALSE, so newlines are not allowed
- Override the "ignoreNewlines" setting in a ruleset.xml file to change
- PSR2 ControlStructureSpacingSniff now checks for, and fixes, newlines after the opening parenthesis
- Added a markdown document generator (--generator=markdown to use)
- Thanks to [Stefano Kowalke][@Konafets] for the contribution

### Fixed
- Fixed bug #379 : Squiz.Arrays.ArrayDeclaration.NoCommaAfterLast incorrectly detects comments
- Fixed bug #382 : JS tokenizer incorrect for inline conditionally created immediately invoked anon function
- Fixed bug #383 : Squiz.Arrays.ArrayDeclaration.ValueNoNewline incorrectly detects nested arrays
- Fixed bug #386 : Undefined offset in Squiz.FunctionComment sniff when param has no comment
- Fixed bug #390 : Indentation of non-control structures isn't adjusted when containing structure is fixed
- Fixed bug #400 : InlineControlStructureSniff fails to fix when statement has no semicolon
- Fixed bug #401 : PHPCBF no-patch option shows an error when there are no fixable violations in a file
- Fixed bug #405 : The "Squiz.WhiteSpace.FunctionSpacing" sniff removes class "}" during fixing
- Fixed bug #407 : PEAR.ControlStructures.MultiLineCondition doesn't account for comments at the end of lines
- Fixed bug #410 : The "Squiz.WhiteSpace.MemberVarSpacing" not respecting "var"
- Fixed bug #411 : Generic.WhiteSpace.ScopeIndent.Incorrect - false positive with multiple arrays in argument list
- Fixed bug #412 : PSR2 multi-line detection doesn't work for inline IF and string concats
- Fixed bug #414 : Squiz.WhiteSpace.MemberVarSpacing - inconsistent checking of member vars with comment
- Fixed bug #433 : Wrong detection of Squiz.Arrays.ArrayDeclaration.KeyNotAligned when key contains space
- Fixed bug #434 : False positive for spacing around "=>" in inline array within foreach
- Fixed bug #452 : Ruleset exclude-pattern for specific sniff code ignored when using CLI --ignore option
- Fixed bug #20482 : Scope indent sniff can get into infinite loop when processing a parse error
- Fixed bug [#379][sq-379] : Squiz.Arrays.ArrayDeclaration.NoCommaAfterLast incorrectly detects comments
- Fixed bug [#382][sq-382] : JS tokenizer incorrect for inline conditionally created immediately invoked anon function
- Fixed bug [#383][sq-383] : Squiz.Arrays.ArrayDeclaration.ValueNoNewline incorrectly detects nested arrays
- Fixed bug [#386][sq-386] : Undefined offset in Squiz.FunctionComment sniff when param has no comment
- Fixed bug [#390][sq-390] : Indentation of non-control structures isn't adjusted when containing structure is fixed
- Fixed bug [#400][sq-400] : InlineControlStructureSniff fails to fix when statement has no semicolon
- Fixed bug [#401][sq-401] : PHPCBF no-patch option shows an error when there are no fixable violations in a file
- Fixed bug [#405][sq-405] : The "Squiz.WhiteSpace.FunctionSpacing" sniff removes class "}" during fixing
- Fixed bug [#407][sq-407] : PEAR.ControlStructures.MultiLineCondition doesn't account for comments at the end of lines
- Fixed bug [#410][sq-410] : The "Squiz.WhiteSpace.MemberVarSpacing" not respecting "var"
- Fixed bug [#411][sq-411] : Generic.WhiteSpace.ScopeIndent.Incorrect - false positive with multiple arrays in argument list
- Fixed bug [#412][sq-412] : PSR2 multi-line detection doesn't work for inline IF and string concats
- Fixed bug [#414][sq-414] : Squiz.WhiteSpace.MemberVarSpacing - inconsistent checking of member vars with comment
- Fixed bug [#433][sq-433] : Wrong detection of Squiz.Arrays.ArrayDeclaration.KeyNotAligned when key contains space
- Fixed bug [#434][sq-434] : False positive for spacing around "=>" in inline array within foreach
- Fixed bug [#452][sq-452] : Ruleset exclude-pattern for specific sniff code ignored when using CLI --ignore option
- Fixed bug [#20482][pear-20482] : Scope indent sniff can get into infinite loop when processing a parse error

[sq-348]: https://github.com/squizlabs/PHP_CodeSniffer/issues/348
[sq-375]: https://github.com/squizlabs/PHP_CodeSniffer/issues/375
[sq-377]: https://github.com/squizlabs/PHP_CodeSniffer/issues/377
[sq-379]: https://github.com/squizlabs/PHP_CodeSniffer/issues/379
[sq-382]: https://github.com/squizlabs/PHP_CodeSniffer/issues/382
[sq-383]: https://github.com/squizlabs/PHP_CodeSniffer/issues/383
[sq-386]: https://github.com/squizlabs/PHP_CodeSniffer/issues/386
[sq-390]: https://github.com/squizlabs/PHP_CodeSniffer/issues/390
[sq-392]: https://github.com/squizlabs/PHP_CodeSniffer/issues/392
[sq-400]: https://github.com/squizlabs/PHP_CodeSniffer/issues/400
[sq-401]: https://github.com/squizlabs/PHP_CodeSniffer/issues/401
[sq-405]: https://github.com/squizlabs/PHP_CodeSniffer/issues/405
[sq-407]: https://github.com/squizlabs/PHP_CodeSniffer/issues/407
[sq-410]: https://github.com/squizlabs/PHP_CodeSniffer/issues/410
[sq-411]: https://github.com/squizlabs/PHP_CodeSniffer/issues/411
[sq-412]: https://github.com/squizlabs/PHP_CodeSniffer/issues/412
[sq-414]: https://github.com/squizlabs/PHP_CodeSniffer/issues/414
[sq-423]: https://github.com/squizlabs/PHP_CodeSniffer/issues/423
[sq-433]: https://github.com/squizlabs/PHP_CodeSniffer/issues/433
[sq-434]: https://github.com/squizlabs/PHP_CodeSniffer/issues/434
[sq-452]: https://github.com/squizlabs/PHP_CodeSniffer/issues/452
[pear-20481]: https://pear.php.net/bugs/bug.php?id=20481
[pear-20482]: https://pear.php.net/bugs/bug.php?id=20482

## [2.1.0] - 2014-12-18
### Changed
- Time and memory output is now shown if progress information is also shown (request #335)
- A tilde can now be used to reference a user's home directory in a path to a standard (request #353)
- Time and memory output is now shown if progress information is also shown (request [#335][sq-335])
- A tilde can now be used to reference a user's home directory in a path to a standard (request [#353][sq-353])
- Added PHP_CodeSniffer_File::findStartOfStatement() to find the first non-whitespace token in a statement
- Possible alternative for code using PHP_CodeSniffer_File::findPrevious() with the local flag set
- Added PHP_CodeSniffer_File::findEndOfStatement() to find the last non-whitespace token in a statement
Expand All @@ -3855,7 +3879,7 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
- Affects OpeningFunctionBraceBsdAllmanSniff and OpeningFunctionBraceKernighanRitchieSniff
- Also enforced in PEAR FunctionDeclarationSniff and Squiz MultiLineFunctionDeclarationSniff
- Generic DisallowTabIndentSniff now replaces tabs everywhere it finds them, except in strings and here/now docs
- Generic EmptyStatementSniff error codes now contain the type of empty statement detected (request #314)
- Generic EmptyStatementSniff error codes now contain the type of empty statement detected (request [#314][sq-314])
- All messages generated by this sniff are now errors (empty CATCH was previously a warning)
- Message code Generic.CodeAnalysis.EmptyStatement.NotAllowed has been removed
- Message code Generic.CodeAnalysis.EmptyStatement.NotAllowedWarning has been removed
Expand All @@ -3865,7 +3889,7 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
- PEAR and Squiz FunctionCommentSniffs no longer ban @return tags for constructors and destructors
- Removed message PEAR.Commenting.FunctionComment.ReturnNotRequired
- Removed message Squiz.Commenting.FunctionComment.ReturnNotRequired
- Change initiated by request #324 and request #369
- Change initiated by request [#324][sq-324] and request [#369][sq-369]
- Squiz EmptyStatementSniff has been removed
- Squiz standard now includes Generic EmptyStatementSniff and turns off the empty CATCH error
- Squiz ControlSignatureSniff fixes now retain comments between the closing parenthesis and open brace
Expand All @@ -3874,21 +3898,41 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
- Squiz ArrayDeclarationSniff now skips function calls while checking multi-line arrays

### Fixed
- Fixed bug #337 : False positive with anonymous functions in Generic_Sniffs_WhiteSpace_ScopeIndentSniff
- Fixed bug #339 : reformatting brace location can result in broken code
- Fixed bug #342 : Nested ternary operators not tokenized correctly
- Fixed bug #345 : Javascript regex not tokenized when inside array
- Fixed bug #346 : PHP path can't be determined in some cases in "phpcs.bat" (on Windows XP)
- Fixed bug #358 : False positives for Generic_Sniffs_WhiteSpace_ScopeIndentSniff
- Fixed bug #361 : Sniff-specific exclude patterns don't work for Windows
- Fixed bug #364 : Don't interpret "use function" as declaration
- Fixed bug #366 : phpcbf with PSR2 errors on control structure alternative syntax
- Fixed bug #367 : Nested Anonymous Functions Causing False Negative
- Fixed bug #371 : Shorthand binary cast causes tokenizer errors
- Fixed bug [#337][sq-337] : False positive with anonymous functions in Generic_Sniffs_WhiteSpace_ScopeIndentSniff
- Fixed bug [#339][sq-339] : reformatting brace location can result in broken code
- Fixed bug [#342][sq-342] : Nested ternary operators not tokenized correctly
- Fixed bug [#345][sq-345] : Javascript regex not tokenized when inside array
- Fixed bug [#346][sq-346] : PHP path can't be determined in some cases in "phpcs.bat" (on Windows XP)
- Fixed bug [#358][sq-358] : False positives for Generic_Sniffs_WhiteSpace_ScopeIndentSniff
- Fixed bug [#361][sq-361] : Sniff-specific exclude patterns don't work for Windows
- Fixed bug [#364][sq-364] : Don't interpret "use function" as declaration
- Fixed bug [#366][sq-366] : phpcbf with PSR2 errors on control structure alternative syntax
- Fixed bug [#367][sq-367] : Nested Anonymous Functions Causing False Negative
- Fixed bug [#371][sq-371] : Shorthand binary cast causes tokenizer errors
- New token T_BINARY_CAST added for the b"string" cast format (the 'b' is the T_BINARY_CAST token)
- Fixed bug #372 : phpcbf parse problem, wrong brace placement for inline IF
- Fixed bug #373 : Double quote usage fix removing too many double quotes
- Fixed bug #20196 : 1.5.2 breaks scope_closer position
- Fixed bug [#372][sq-372] : phpcbf parse problem, wrong brace placement for inline IF
- Fixed bug [#373][sq-373] : Double quote usage fix removing too many double quotes
- Fixed bug [#20196][pear-20196] : 1.5.2 breaks scope_closer position

[sq-314]: https://github.com/squizlabs/PHP_CodeSniffer/issues/314
[sq-324]: https://github.com/squizlabs/PHP_CodeSniffer/issues/324
[sq-335]: https://github.com/squizlabs/PHP_CodeSniffer/issues/335
[sq-337]: https://github.com/squizlabs/PHP_CodeSniffer/issues/337
[sq-339]: https://github.com/squizlabs/PHP_CodeSniffer/issues/339
[sq-342]: https://github.com/squizlabs/PHP_CodeSniffer/issues/342
[sq-345]: https://github.com/squizlabs/PHP_CodeSniffer/issues/345
[sq-346]: https://github.com/squizlabs/PHP_CodeSniffer/issues/346
[sq-353]: https://github.com/squizlabs/PHP_CodeSniffer/issues/353
[sq-358]: https://github.com/squizlabs/PHP_CodeSniffer/issues/358
[sq-361]: https://github.com/squizlabs/PHP_CodeSniffer/issues/361
[sq-364]: https://github.com/squizlabs/PHP_CodeSniffer/pull/364
[sq-366]: https://github.com/squizlabs/PHP_CodeSniffer/issues/366
[sq-367]: https://github.com/squizlabs/PHP_CodeSniffer/issues/367
[sq-369]: https://github.com/squizlabs/PHP_CodeSniffer/issues/369
[sq-371]: https://github.com/squizlabs/PHP_CodeSniffer/issues/371
[sq-372]: https://github.com/squizlabs/PHP_CodeSniffer/issues/372
[sq-373]: https://github.com/squizlabs/PHP_CodeSniffer/issues/373
[pear-20196]: https://pear.php.net/bugs/bug.php?id=20196

## [2.0.0] - 2014-12-05
### Changed
Expand Down Expand Up @@ -3920,9 +3964,13 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
- Improved fixing of lines after cases statements in Squiz SwitchDeclarationSniff

### Fixed
- Fixed bug #311 : Suppression of function prototype breaks checking of lines within function
- Fixed bug #320 : Code sniffer indentation issue
- Fixed bug #333 : Nested ternary operators causing problems
- Fixed bug [#311][sq-311] : Suppression of function prototype breaks checking of lines within function
- Fixed bug [#320][sq-320] : Code sniffer indentation issue
- Fixed bug [#333][sq-333] : Nested ternary operators causing problems

[sq-311]: https://github.com/squizlabs/PHP_CodeSniffer/issues/311
[sq-320]: https://github.com/squizlabs/PHP_CodeSniffer/issues/320
[sq-333]: https://github.com/squizlabs/PHP_CodeSniffer/issues/333

## [1.5.6] - 2014-12-05
### Changed
Expand Down