Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: add new PreexistingPHPCSConfigTest #166

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Mar 5, 2022

Proposed Changes

This new test class tests that the plugin handles a pre-existing PHPCS configuration file correctly.

These tests verify:

  • That the plugin will add the installed_paths setting correctly.
  • That the plugin does not remove or alter existing configurations, except for the installed_paths.

Notes:

  • As PHPCS behaves the same whether installed locally or globally, it is unnecessary to run the tests in both type of environments.
  • As the output of the config-show command in PHPCS has changed across PHPCS version, it is necessary to test against multiple PHPCS versions.

Related Issues

This test class covers the following bug previously reported:

Related to #92

This new test class tests that the plugin handles a pre-existing PHPCS configuration file correctly.

These tests verify:
- That the plugin will add the `installed_paths` setting correctly.
- That the plugin does not remove or alter existing configurations, except for the `installed_paths`.

Notes:
* As PHPCS behaves the same whether installed locally or globally, it is unnecessary to run the tests in both type of environments.
* As the output of the `config-show` command in PHPCS has changed across PHPCS version, it is necessary to test against multiple PHPCS versions.

This test class covers the following bug previously reported:
* Dealerdirect/phpcodesniffer-composer-installer PR 98
@Potherca Potherca merged commit 27d906d into master Apr 18, 2022
@Potherca Potherca deleted the feature/tests-new-preexistingphpcsconfig-test branch April 18, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants