add possibility to register namespaces to DOMXpath #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@troosan That lacks an unit test :) |
|
The whole class is lacking unit tests ;-) |
|
@troosan Yes... but we are in continuous improvment :) |
|
@Progi1984 In the spirit of constant improvement, 100% code coverage for the XMLReader |
|
@troosan Good job :) |
2 tasks
|
@Progi1984 do you think we could release a 0.2.8? |
|
@Progi1984 are you planning on adding anything else before releasing a new version? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.