Nationals #37
Merged
Nationals #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #38.
Without this, the checkboxes would not be rendered correctly. They weren't checked when the user clicked on them. This was due to another annoying csp violation. Oversight on my part. I apologize, I hope this is the last time I have to fix this.
54 characters removed, for a total of a 50 line reduction of code!
Bump preact. Downgrade gfm to a csr compatible version. HeadlessUI v2.0 is broken, and HeadlessUI v1.18 added code from v2.0. It's mostly turned off, but it's still in the bundle. It relies on process.env.JEST_WORKER_ID to disable some features. We use combobox, the affected component, so we can't upgrade.
I disabled some rules: useDefaultSwitchClause doesn't have type information.
It found a real bug in compile-mdx. Luckily, JS was lenient enough it didn't make a big deal.
The csp didn't work right with latest fresh.
Apparently f-client-nav requires the direct child to be a partial. It works fine otherwise, so I hadn't noticed. However, it turns out `f-client-nav`ed islands must be partialled.
I gave up on streaming for now, but this is still a nice simplification.
Upgrade Dependencies
Fix Homepage Dark Mode
Refactor Path Resolution Logic in MDX Compilation File Discovery
Fix Missing Partial Island Warning
|
I'm going to go ahead and merge this seeing as this both fixes bugs on main, and GH doesn't like stacking PRs, even just with a trunk-based workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes code that'll be deployed for nationals, should we make it that far, but which can't be deployed for state.