Imports, Exports, Types, and Style #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I figured out how to type-annotate Preact functions, so I murdered the lamdas! Hooray for genocide!* * Genocide is terrible. The atrocious acts by - the Russians in Ukraine, - the Nazis in the Holocaust, - and many others, like in Somalia and Vietnam, are not to be tolerated at any cost, lest history repeat itself. In lighter topics, back to vanquishing poor coding style!
Now that these interfaces are exposed, they should have good types. Also, I asked copilot to simplify a bit of logic in the header to make up for the added complexity. In addition, I more consistently used optional properties over undefined types.
Simplify code in a manner after God's own heart. Or maybe just mine. This fixes a lot of type holes. We now use template literal types, custom type literal functions, and don't use casts. In addition, a lot more things are `readonly` or `const` now. Down with mutability! UI-wise, I removed the link to the homepage in the header, because you can just click the "logo." This simplifies quite a bit of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I botched up merging #7.