fix : for문 제거

PICK-PLE · Aug 12, 2024 · 6c5aba6 · 6c5aba6
1 parent 3e35da0
commit 6c5aba6
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/...main/java/com/pickple/server/api/moimsubmission/service/MoimSubmissionCommandService.java b/...main/java/com/pickple/server/api/moimsubmission/service/MoimSubmissionCommandService.java
@@ -52,14 +52,13 @@ public void updateSubmissionState(Long moimId, List<Long> submitterIdList) {
                     moimSubmission.updateMoimSubmissionState(MoimSubmissionState.APPROVED.getMoimSubmissionState());
                 }
             }
-            moimSubmissionRepository.save(moimSubmission);
-        }
-        //승인 이후에 승인 대기(pendingApproval)인 요청에 대해 승인 거절(rejected)상태로 변경
-        for (MoimSubmission moimSubmission : moimSubmissionList) {
+
+            //승인 이후에 승인 대기(pendingApproval)인 요청에 대해 승인 거절(rejected)상태로 변경
             if (moimSubmission.getMoimSubmissionState()
                     .equals(MoimSubmissionState.PENDING_APPROVAL.getMoimSubmissionState())) {
                 moimSubmission.updateMoimSubmissionState(MoimSubmissionState.REJECTED.getMoimSubmissionState());
             }
+            moimSubmissionRepository.save(moimSubmission);
         }
     }
 }