add creation of petl_load_times #386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseaton
requested changes
Nov 1, 2022
| <changeSet id="20221101-initial-create-of-petl-load-times-table" author="ddesimone"> | ||
| <preConditions onFail="MARK_RAN"> | ||
| <sqlCheck expectedResult="0"> | ||
| select table_exists("petl_load_times"); |
There was a problem hiding this comment.
Better to follow existing standard and conventions here. See where I add the authentication_event_log table. Something like:
<not><tableExists tableName="petl_load_times"/></not>
| create table petl_load_times | ||
| (loaded_domain varchar(50), | ||
| last_loaded_time datetime); | ||
| </sql> |
There was a problem hiding this comment.
Again, better to use the liquibase constructs for this, as done throughout this liquibase.xml file. First, no need (and not desireable) to have the drop table if exists... statement. Your precondition already guarantees that it doesn't exist. Second, in order to create the table, use the liquibase tags for this (again, see where I add the authentication event log table). Something like:
<createTable tableName="petl_load_times">
<column name="loaded_domain" type="varchar(50)"/>
<column name="last_loaded_time" type="datetime"/>
</createTable>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.