Tip lock handling in tier two. #1656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o tip updates and trigger updates in payments and budgets. Should significantly reduce number of references to chainActive.Tip(). Update miner_test for mnpayments
…rrentBlockIndex is an overkill here, we should just make sure that cs_main lock is already held for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is coming from #710 + adapted to our sources.
Can be taken as a good performance improvement for 4.2 over the tier two
cs_mainlock usage (without make radical changes).5.0 will need to have major changes in this area.
cs_mainlock.chainActiveover the tier two sources.CBlockIndex* currentTipmember on each of the tier two objects to not have to re request the tip, lockingcs_main, on every validation/action.-- Needs proper testing --