Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai): 区分SCOW和SCOW AI使用的有关适配器请求的公共逻辑函数 #1369

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

piccaSun
Copy link
Contributor

@piccaSun piccaSun commented Jul 19, 2024

背景

因为适配器接口版本已分开,以后可能因为接口增加或变更使client类型已不再一致, 会出现报错

修改后

listAppSessions, checkAppConnectivity, connectToApp 三个使用了公共接口的地方,页面表现与当前主分支表现一致

Copy link

changeset-bot bot commented Jul 19, 2024

⚠️ No Changeset found

Latest commit: 50d0bcd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@piccaSun piccaSun changed the title fix(ai): 区分SCOW和SCOW AI使用的公共函数 fix(ai): 区分SCOW和SCOW AI使用的适配器请求的公共函数 Jul 19, 2024
@piccaSun piccaSun marked this pull request as ready for review July 19, 2024 09:01
@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label Jul 19, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal July 19, 2024 09:01
@piccaSun piccaSun changed the title fix(ai): 区分SCOW和SCOW AI使用的适配器请求的公共函数 fix(ai): 区分SCOW和SCOW AI使用的有关适配器请求的公共逻辑函数 Jul 19, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-Approved Code Review approved ReadyForMerge Ready for merge and removed Code-ReviewRequested Code Review Requested labels Jul 22, 2024
@ddadaal ddadaal merged commit 6428d9b into master Jul 22, 2024
15 checks passed
@ddadaal ddadaal deleted the fix-ai-import-adapter-client branch July 22, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code-Approved Code Review approved ReadyForMerge Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants