Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(portal): 交互式应用增加说明文字功能 #886

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

piccaSun
Copy link
Contributor

@piccaSun piccaSun commented Oct 10, 2023

做了什么

{app}.yaml中增加appComment, 允许管理员配置交互式应用说明文字,支持HTML标签,展示在创建应用页面下方
实现效果如下
image

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

🦋 Changeset detected

Latest commit: 2b41482

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@scow/portal-server Patch
@scow/portal-web Patch
@scow/config Patch
@scow/grpc-api Patch
@scow/lib-hook Patch
@scow/lib-operation-log Patch
@scow/audit-server Patch
@scow/auth Patch
@scow/cli Patch
@scow/mis-server Patch
@scow/mis-web Patch
@scow/protos Patch
@scow/lib-scheduler-adapter Patch
@scow/gateway Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6bf6a6e) 70.58% compared to head (2b41482) 70.56%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
- Coverage   70.58%   70.56%   -0.02%     
==========================================
  Files         130      130              
  Lines        3722     3723       +1     
  Branches      497      498       +1     
==========================================
  Hits         2627     2627              
  Misses       1001     1001              
- Partials       94       95       +1     
Files Coverage Δ
apps/portal-server/src/services/app.ts 48.35% <33.33%> (-0.54%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-11 12:39 UTC

@piccaSun piccaSun marked this pull request as ready for review October 11, 2023 07:15
@piccaSun piccaSun requested a review from ddadaal October 11, 2023 07:15
@ddadaal ddadaal merged commit 8fc4c21 into master Oct 11, 2023
10 checks passed
@ddadaal ddadaal deleted the feat-add-app-explanation-config branch October 11, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants